feat: rename an attachment to be saved in Files - #13360
Open
madbob wants to merge 1 commit into
Open
Conversation
Signed-off-by: Roberto Guido <info@madbob.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an extra button to the
FilePickermodal used to save an attachment to Files, opening a new modal which permits to overwrite the filename to be used.I tried to ask to embed this functionality (= specify a filename) directly into
FilePickerbut the request has been rejected. This is fair, as this use case doesn't seems to be widely common across Nextcloud apps: perhaps one day this will change, but right now seems an overkill to embed this directly in the shared library.Note that the extra modal may later be used to perform other operations while saving an attachment to Files, e.g. attaching tags (#604), without depending to
FilePickerabilities.Fixes #1827