Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #953 +/- ##
=======================================
Coverage 94.77% 94.77%
=======================================
Files 10 10
Lines 746 746
Branches 235 235
=======================================
Hits 707 707
Misses 36 36
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft pins urllib's main CI workflow to merged setup-vp commit
6eb3ef76e48ad5aca2d217e4ee277786b3865699from setup-vp #209. The global CLI, localvite-plus, andvitealias use preview65f9bc56f1f2d87e138013c5bcde9e7306d8eeb8. The lockfile and registry setting match that preview.A validated toolchain cache hit now activates the cached native CLI directly. The action skips installer downloads and persistent
PATHchanges. It still uses the installer if native activation fails. The package-manager binary remains in a separate archive.The benchmark below measures pre-merge revision
06fe7ecfda756e5871867245052c17baa9b4e974.The GitHub Actions comparison passed all 57 jobs: three cache warm-ups and six samples per case on each platform. Every job uses the same urllib checkout and tool versions. Each job builds urllib after setup.
The table shows median setup + post time. All three cases ran in this comparison. The baseline has no package-manager binary cache. The previous and latest revisions restore that archive.
All measured jobs restored the same dependency and Vite+/Node.js archives for their platform. All 36 previous/latest samples also restored the pnpm archive. All 18 latest samples used native activation without installer fallback.
Windows shows the clearest activation saving. The following phase starts after toolchain restoration and ends when Node.js setup starts.
The package-manager archive still adds lookup, transfer, extraction, and executable checks. Cache-transfer and runner variation also affect total time, especially on macOS. These six-sample medians describe this run; they do not guarantee the same percentage on every run.
Revisions, method, raw samples, and cache size
c025a93923d2f9c524652d786386d11065fc3e8f85cf606c7348256a70a82b783b3cb2ff1e2b703b06fe7ecfda756e5871867245052c17baa9b4e974The benchmark workflow checks out urllib
8d14d55acb8886a2de1102f09abd008c38560c55. All cases use Node.js24.22.0andpnpm@12.14.0. The preview version is0.0.0-commit.65f9bc56f1f2d87e138013c5bcde9e7306d8eeb8.Each platform starts with fresh, isolated toolchain and dependency paths. One warm-up saves its three archives. All measured jobs set
cache-save: falseand runvp installon separate hosted runners. Both earlier revisions and the latest revision disablesfwfor this preview.The measurement includes the setup action and its post step. It excludes warm-up, runner startup, checkout, assertions, builds, and artifact uploads. GitHub reports step durations with one-second resolution. The analysis checks matching tool versions, lockfile hashes, pnpm binary hashes, cache keys, and runner images within each platform.
The compressed archives use this storage:
The pnpm archives add about 59 MiB across all three platforms. The existing
cache-toolchaininput controls the manager archive.package-manager-cache-hitreports manager restoration;toolchain-cache-hitreports the Vite+/Node.js archive.The benchmark workflow remains outside this PR's diff. Its isolated caches do not seed normal PR CI. The normal Node.js matrix and cache-save policy remain in place.