Skip to content

lookup: unskip glob - #1140

Draft
abhayagarwal-dev wants to merge 1 commit into
nodejs:mainfrom
abhayagarwal-dev:unskip-s390
Draft

abhayagarwal-dev wants to merge 1 commit into
nodejs:mainfrom
abhayagarwal-dev:unskip-s390

Conversation

@abhayagarwal-dev

@abhayagarwal-dev abhayagarwal-dev commented Sep 18, 2026

Copy link
Copy Markdown

glob was marked as skip: true in 8bad32f because it was failing
on Travis CI. Travis CI is no longer used by glob — it has been
replaced by GitHub Actions which is currently passing.

Official Node.js CI results show glob passes on all Linux platforms:

11:57:54 Completed citgm-smoker-nobuild » fedora-latest-x64 SUCCESS
11:59:39 Completed citgm-smoker-nobuild » win-vs2022_clang FAILURE
12:09:41 Completed citgm-smoker-nobuild » aix73-power9 SUCCESS
12:09:41 Completed citgm-smoker-nobuild » ubuntu2404-x64 SUCCESS
12:09:41 Completed citgm-smoker-nobuild » rhel9-ppc64le SUCCESS
12:09:41 Completed citgm-smoker-nobuild » macos15-x64 FAILURE
12:09:41 Completed citgm-smoker-nobuild » win-vs2022_clang-arm64 FAILURE
12:09:41 Completed citgm-smoker-nobuild » rhel9-x64 SUCCESS
12:09:41 Completed citgm-smoker-nobuild » rhel9-s390x SUCCESS
12:09:41 Completed citgm-smoker-nobuild » debian13-x64 SUCCESS
12:09:41 Completed citgm-smoker-nobuild » macos15-arm64 FAILURE

Removing global skip: true and adding skip: ["win32", "darwin"]
to only skip platforms that consistently fail.

  • npm test passes

  • contribution guidelines followed
    here

@abhayagarwal-dev

Copy link
Copy Markdown
Author

Will mark ready for review once get citgm-smoker Jenkins CI results .
@nodejs/citgm could someone trigger a CI run?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant