zlib: decode concatenated zstd frames#64748
Open
lazerg wants to merge 1 commit into
Open
Conversation
nodejs-github-bot
added
c++
ZstdDecompressContext::DoThreadPoolWork decoded a single frame per call, so a stream that received several concatenated frames in one write kept only the first frame and dropped the rest. Other codecs that support concatenation, such as gunzip, already loop over the remaining input. Keep decoding while a frame ends with input still pending and output space available, and thread rejectGarbageAfterEnd through to the zstd context so trailing frames are still rejected when that option is set. Signed-off-by: Lazizbek Ergashev <lazerg2@gmail.com>
lazerg
force-pushed
the
fix/issue-64741-zstd-concatenated-frames
branch
from
July 26, 2026 02:02
f179d4f to
f8088e7
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64748 +/- ##
==========================================
- Coverage 90.15% 90.12% -0.03%
==========================================
Files 743 743
Lines 242413 242427 +14
Branches 45657 45657
==========================================
- Hits 218537 218484 -53
- Misses 15362 15440 +78
+ Partials 8514 8503 -11
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a single write held several concatenated zstd frames, decompression stopped after the first one and dropped the rest. The zstd format allows concatenated frames, and both
zstdcatand gunzip decode them, so a stream should too.ZstdDecompressContext::DoThreadPoolWorkran a single decode call per invocation. Once the first frame finished with input left over and output space still free, the processing loop read that as the end of the stream. It now keeps decoding across frame boundaries, the same way the gunzip path walks concatenated members. The existingrejectGarbageAfterEndoption is passed through to the zstd context, so trailing frames are still rejected when it is set.Fixes: #64741