Skip to content

sea: reject trailing content in config JSON - #64774

Open
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:sea4
Open

sea: reject trailing content in config JSON#64774
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:sea4

Conversation

@Archkon

@Archkon Archkon commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Ensure the on-demand parser reaches the end of the document after reading the root object. Reject concatenated JSON values with TRAILING_CONTENT

Ensure the on-demand parser reaches the end of the document after
reading the root object. Reject concatenated JSON values with
TRAILING_CONTENT

Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/single-executable

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. single-executable Issues and PRs related to single-executable applications labels Jul 27, 2026
@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.13%. Comparing base (54a5095) to head (f2d4b1f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #64774      +/-   ##
==========================================
- Coverage   90.14%   90.13%   -0.01%     
==========================================
  Files         744      744              
  Lines      242518   242524       +6     
  Branches    45685    45698      +13     
==========================================
- Hits       218611   218609       -2     
- Misses      15396    15432      +36     
+ Partials     8511     8483      -28     
Files with missing lines Coverage Δ
src/node_sea.cc 89.63% <100.00%> (+0.10%) ⬆️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. single-executable Issues and PRs related to single-executable applications

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants