systemd: use sync.WaitGroup.Go in TestParallelConnection - #82
Merged
Merged
Conversation
Now that we require Go 1.25, use the newly added WaitGroup.Go method. Since Go 1.22, loop variables are per-iteration, so there is no need to pass dm as an argument to the goroutine. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
AkihiroSuda
approved these changes
Oct 2, 2026
thaJeztah
approved these changes
Oct 3, 2026
thaJeztah
left a comment
thaJeztah
left a comment
Member
There was a problem hiding this comment.
ah, nice; yes I like this API much more 😂
Wondering why go fix or the modernize linter didn't pick it up here 🤔
LGTM
Contributor
Author
See this PR description ;) |
Member
|
LOL; I should learn to read 😂 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we require Go 1.25, use the newly added
WaitGroup.Gomethod.Since Go 1.22, loop variables are per-iteration, so there is no need
to pass
dmas an argument to the goroutine.Neither
modernizenorgo fixcatch this one (because of the goroutineargument), and this is the only
sync.WaitGroupin the repo.