feat: add max-header-length for header length check#85
Open
aj3sh wants to merge 1 commit into
Open
Conversation
sugat009
reviewed
Mar 18, 2026
sugat009
left a comment
sugat009
left a comment
Contributor
There was a problem hiding this comment.
Supply chain security: please keep SHA pins for write-privileged actions. See inline comments.
sugat009
reviewed
Mar 18, 2026
sugat009
left a comment
sugat009
left a comment
Contributor
There was a problem hiding this comment.
Bug: --max-header-length falsy check allows invalid values. See inline comment with reproduction steps.
sugat009
reviewed
Mar 18, 2026
sugat009
left a comment
sugat009
left a comment
Contributor
There was a problem hiding this comment.
Question on the architectural direction for configurable validator options. See inline comment.
sugat009
reviewed
Mar 18, 2026
sugat009
left a comment
sugat009
left a comment
Contributor
There was a problem hiding this comment.
Additional review comments using conventional comments labels.
sugat009
requested changes
Mar 18, 2026
aj3sh
force-pushed
the
max-header-length
branch
from
March 28, 2026 16:07
be9b5b3 to
7844137
Compare
aj3sh
force-pushed
the
max-header-length
branch
from
April 12, 2026 11:42
7844137 to
3c7c482
Compare
sugat009
requested changes
Apr 20, 2026
sugat009
left a comment
sugat009
left a comment
Contributor
There was a problem hiding this comment.
Review: feat: add max-header-length
Good feature addition overall. The AppParams dataclass is well-proportioned, positive_int_type handles edge cases correctly, and the validate_fns rename removes ambiguity with the module name.
Two test bugs need fixing before merge, and one product decision needs resolution. See inline comments.
Findings
| # | Label | File | Finding |
|---|---|---|---|
| 1 | issue (blocking) | test__linter.py:29 |
skip_detail test passes False instead of True (copy-paste bug) |
| 2 | issue (blocking) | test_run_commitlint.py:65 |
All 4 tests fail in isolation due to env var leakage |
| 3 | question (blocking) | validators.py:77 |
Breaking change: header length check is now opt-in (was always 72) |
| 4 | issue | utils.py:67 |
Docstring claims "returns None" but raises ValueError |
| 5 | suggestion | utils.py:76 |
Add positive-int validation to match CLI path |
| 6 | suggestion | cli.py:276 |
DRY: extract AppParams construction with dataclasses.replace |
| 7 | suggestion | test_cli.py:409 |
Missing test coverage for --file/--hash/--from-hash + max-header-length |
| 8 | nitpick | app_params.py:18 |
Typo: "Specially" and "Github" |
| 9 | nitpick | validators.py:36 |
self.params public vs self._commit_message private |
| 10 | suggestion | release-please.yml:22 |
Pin actions to commit hashes in privileged workflow |
aj3sh
force-pushed
the
max-header-length
branch
3 times, most recently
from
May 17, 2026 13:11
b217a77 to
75cfe78
Compare
- [Breaking change] disable default header length check - update dependency actions version - add release details on contributing file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Fixes #67
Type of Change
Please mark the appropriate option below to describe the type of change your pull request introduces:
Checklist
Examples:
"fix: Fixed foobar bug","feat(accounts): Added foobar feature".README.md.Additional Notes
[Add any additional notes or context that you think the reviewers should know about.]
By submitting this pull request, I confirm that I have read and complied with the contribution guidelines of this project.