Add resources required to run lightspeed-tests - #4140
jancervenka wants to merge 1 commit into
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
77088b0 to
9c76c36
Compare
|
Hi @malingatembo! we were discussing with @lpiwowar (see: openstack-k8s-operators/lightspeed-tests#12) create some additional resources in your playbook. The resources are required by the test-operator to successfully run the lightspeed-test suite. See the commit message:
|
|
@jancervenka thanks for the PR! 🎉 The initial idea was for this PR to build on top of @malingatembo's PR. We can then use If it turns out that the changes you introduced work, then we can merge both PRs into one (into @malingatembo's PR #4108 with a proper commit attributing your work, of course :). I suggest:
Just want to say that we are getting a little bit ahead ourselves here. But if everything clicks then the PR merging is going to be easy. Also, I'm personally ok just waiting it out until the job @malingatembo is working on gets ready. One way or the other I would mark this as a draft for now 🙈 . |
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
the PR is checked out of @malingatembo's work and marked as a draft. |
9c76c36 to
074d40d
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
074d40d to
ff2d569
Compare
|
Build succeeded (check pipeline). ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 43m 10s |
test-operator expects a ConfigMap and two secrets to exists before it will start executing a test suite. We create the expected dummy resources with not data to satisfy the requirement. test-operator is using the default ServiceAccount to run this test. We need to create a ClusterRole and ClusterRoleBinding to grant the default SA access to the Lightspeed service. Signed-off-by: Jan Cervenka <jcervenk@redhat.com>
ff2d569 to
c9f6ee7
Compare
|
Build succeeded (check pipeline). ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 22m 55s |
2 participants
test-operator expects a ConfigMap and two secrets to exists before it will start executing a test suite. We create the expected dummy resources with no data to satisfy the requirement.
test-operator is using the default ServiceAccount to run the tests. We need to create a ClusterRole and ClusterRoleBinding to grant the default SA access to the Lightspeed service.