[skip ci] UPGRADING: add missing RFC links and some more small fixes - #23645
Open
jrfnl wants to merge 3 commits into
Open
[skip ci] UPGRADING: add missing RFC links and some more small fixes#23645jrfnl wants to merge 3 commits into
jrfnl wants to merge 3 commits into
Conversation
LamentXU123
reviewed
Sep 11, 2026
LamentXU123
left a comment
Member
There was a problem hiding this comment.
Not sure about the GMP part tho. Other commits looks correct.
Contributor
Author
|
@LamentXU123 Want me to move that commit to a separate PR (to unblock the other commits) ? Or do you want us to ping someone who was involved with the GMP change to review that commit ? |
Contributor
Author
|
To clarify why the GMP change is as it is:
|
Member
|
I am not objecting it :) I just want to wait for other's opinion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.