Skip to content

[skip ci] UPGRADING: add missing RFC links and some more small fixes - #23645

Open
jrfnl wants to merge 3 commits into
php:masterfrom
jrfnl:feature/upgrading-add-missing-rfc-link
Open

[skip ci] UPGRADING: add missing RFC links and some more small fixes#23645
jrfnl wants to merge 3 commits into
php:masterfrom
jrfnl:feature/upgrading-add-missing-rfc-link

Conversation

@jrfnl

@jrfnl jrfnl commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@LamentXU123 LamentXU123 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the GMP part tho. Other commits looks correct.

@jrfnl

jrfnl commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

@LamentXU123 Want me to move that commit to a separate PR (to unblock the other commits) ? Or do you want us to ping someone who was involved with the GMP change to review that commit ?

@jrfnl

jrfnl commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

To clarify why the GMP change is as it is:

  1. The move itself was inspired by a) seeing that ValueErrors were mostly listed in section 1 and b) seeing feedback comments asking to move the entries related to ValueErrors to section 1 on PRs related to other changes which introduced ValueErrors.
    It felt like giving that feedback was just overlooked/missed for the PR with the GMP change.
  2. In the original file, line 65-66 and line 678-679 basically explained the same change.
  3. I've merged the text of those four lines to come to what I felt was the most descriptive text to list that change.
  4. The other entries which I moved from section 5 to section 1 are textually unchanged.
  5. The order of the entries is kept the same as the order in which they were listed in section 5.

@LamentXU123

Copy link
Copy Markdown
Member

I am not objecting it :) I just want to wait for other's opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants