ext/zip: ZipArchive::extractTo() ignores files given in a non-list ar… - #23647
Closed
devnexen wants to merge 1 commit into
Closed
ext/zip: ZipArchive::extractTo() ignores files given in a non-list ar…#23647devnexen wants to merge 1 commit into
devnexen wants to merge 1 commit into
Conversation
…ray. The array form walked the entries by synthetic 0..n-1 indices, so a files array with non-sequential keys (as returned by array_filter() and similar) or an integer element extracted nothing while still returning true. It now iterates the array values, honouring every entry regardless of its keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ray.
The array form walked the entries by synthetic 0..n-1 indices, so a files array with non-sequential keys (as returned by array_filter() and similar) or an integer element extracted nothing while still returning true. It now iterates the array values, honouring every entry regardless of its keys.