pgsql: restore binary-safe pg_lo_write() - #23649
Open
iliaal wants to merge 1 commit into
Open
Conversation
NickSdot
reviewed
Sep 11, 2026
Comment on lines
+21
to
+28
| } catch (ValueError $e) { | ||
| echo $e::class, ": ", $e->getMessage(), "\n"; | ||
| } | ||
| try { | ||
| pg_lo_write($handle, "abc", 4); | ||
| } catch (ValueError $e) { | ||
| echo $e::class, ": ", $e->getMessage(), "\n"; | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| } catch (ValueError $e) { | |
| echo $e::class, ": ", $e->getMessage(), "\n"; | |
| } | |
| try { | |
| pg_lo_write($handle, "abc", 4); | |
| } catch (ValueError $e) { | |
| echo $e::class, ": ", $e->getMessage(), "\n"; | |
| } | |
| } catch (Throwable $e) { | |
| echo $e::class, ": ", $e->getMessage(), "\n"; | |
| } | |
| try { | |
| pg_lo_write($handle, "abc", 4); | |
| } catch (Throwable $e) { | |
| echo $e::class, ": ", $e->getMessage(), "\n"; | |
| } |
Member
Author
There was a problem hiding this comment.
catch (Throwable $e)
Both throw from zend_argument_value_error(), and ext/pgsql tests catch the specific type nearly everywhere. Keeping ValueError.
The conversion of the data parameter to Z_PARAM_PATH_STR() made pg_lo_write() reject any data containing a null byte, breaking writes of arbitrary binary payloads which were accepted before. Accept embedded null bytes again by parsing the data as a length-aware string. Sibling audit: the other Z_PARAM_PATH* conversions from the same change (pg_connect(), pg_lo_import(), table/statement identifiers) operate on paths or SQL text where null-byte rejection is intentional.
iliaal
force-pushed
the
fix/aph-puj-lowrite-nul-85
branch
from
September 11, 2026 10:49
67ae8ff to
ba1d0a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pg_lo_write started rejecting payloads with embedded NUL after its data argument was switched to PATH parsing. The argument is a normal string again so binary large-object writes match 8.4. Path and SQL-identifier parameters from that same conversion are unchanged.