ext/sqlite3: reject close() from inside a callback - #23650
Open
iliaal wants to merge 1 commit into
Open
Conversation
NickSdot
reviewed
Sep 11, 2026
Comment on lines
+11
to
+13
| } catch (Error $e) { | ||
| echo $e::class, ": ", $e->getMessage(), "\n"; | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| } catch (Error $e) { | |
| echo $e::class, ": ", $e->getMessage(), "\n"; | |
| } | |
| } catch (Throwable $e) { | |
| echo $e::class, ": ", $e->getMessage(), "\n"; | |
| } |
iliaal
force-pushed
the
fix/sqlite3-close-callback-84
branch
from
September 11, 2026 10:49
79db33f to
a9cc101
Compare
SQLite3::close() called from within a userland function, aggregate, collation or authorizer callback freed the registered statements and functions while sqlite3 was still executing, corrupting the active statement and crashing the request. Track callback re-entry with a per-database counter shared by all four callback kinds and throw an Error from close() while it is non-zero; the database stays usable and can be closed after the query completes.
iliaal
force-pushed
the
fix/sqlite3-close-callback-84
branch
from
September 11, 2026 11:24
a9cc101 to
5c7eec5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLite3::close() from a userland function, aggregate, collation, or authorizer callback finalized statements while SQLite was still in the callback and crashed. close() now throws if a per-database callback counter is non-zero; the handle remains usable until the query finishes.