cli: Automatically execute Closures returned from primary script - #23658
cli: Automatically execute Closures returned from primary script#23658TimWolla wants to merge 1 commit into
Conversation
Girgias
left a comment
There was a problem hiding this comment.
I don't think this needs an RFC, but we may want to punt this to PHP next?
I'm okay with that. Given that Beta 3 is already out and the next version is RC 1 this would be super late otherwise. |
|
A possible alternative to this might be doing something similar to Python: Defining a |
2e2df8e to
f7b047b
Compare
Girgias
left a comment
There was a problem hiding this comment.
Implementation looks good to me. I guess some of the other details might need some discussion on the mailing list.
| } else { | ||
| php_execute_script(&file_handle); | ||
| zval retval; | ||
| ZVAL_UNDEF(&retval); |
There was a problem hiding this comment.
Does php_execute_script_ex not set this to UNDEF?
There was a problem hiding this comment.
I don't trust passing values to zval_ptr_dtor() unless I initialize them myself.
Fair enough, I'll start a thread after the hard freeze. |
Does this require an RFC?