Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ where X.Y.Z is the semver of the most recent choreographer release.

## [Unreleased]

### Fixed
- Build the `ChromeNotFoundError` message as one string, so it no longer prints as a tuple [[#314](https://github.com/plotly/choreographer/pull/314)], with thanks to @Blizzeq for the contribution!


## [1.4.0] -- 2026-09-16

Expand Down
4 changes: 2 additions & 2 deletions src/choreographer/browsers/chromium.py
Original file line number Diff line number Diff line change
Expand Up @@ -190,8 +190,8 @@ def __init__(
raise ChromeNotFoundError(
"Browser not found. You can use get_chrome() or "
"choreo_get_chrome from bash. please see documentation. "
f"Local copy ignored: {self.skip_local}. ",
f"Path calculated:: {self.path}.",
f"Local copy ignored: {self.skip_local}. "
f"Path calculated: {self.path}.",
)
_logger.info(f"Found chromium path: {self.path}")

Expand Down
17 changes: 16 additions & 1 deletion tests/test_chromium.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
from __future__ import annotations

from choreographer.browsers.chromium import Chromium
import pytest

from choreographer.browsers.chromium import ChromeNotFoundError, Chromium
from choreographer.channels import Pipe


Expand Down Expand Up @@ -64,3 +66,16 @@ def test_empty_proxy_server_uses_environment_fallback(tmp_path, monkeypatch):
cli = _get_cli(tmp_path, proxy_server="")

assert "--proxy-server=http://environment.example:8080" in cli


def test_browser_not_found_message_is_one_string(tmp_path):
missing = tmp_path / "chrome"
channel = Pipe()
try:
with pytest.raises(ChromeNotFoundError) as excinfo:
Chromium(channel, missing)
finally:
channel.close()

assert len(excinfo.value.args) == 1
assert f"Path calculated: {missing}." in str(excinfo.value)
Loading