Conversation
The colorbar axis id starts with the orientation letter. The redraw cleanup selected only the tick and title classes for the current letter. After a change of colorbar.orientation, the old elements stayed and inflated the margin push.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the tick labels and the title of the previous orientation when a colorbar changes orientation.
Closes #6973.
Changes
drawAxisremoves the tick label groups for the two axis letters before it draws the ticksdrawTitleremoves all other title classes of the colorbar, not only the class with the otherhprefixThe colorbar axis id is
xoryfollowed byopts._id, and the letter followscolorbar.orientation. The old cleanup selected only the classes for the current letter. Thus the elements of the previous orientation stayed, andpositionCBincluded them in the colorbar size. On 3.x, the stale title width also inverted the axis domain of a short horizontal colorbar, andsetScalethrew.Testing
colorbar_test.js: "removes tick labels and titles of the previous orientation". The test compares the colorbar text and the plot size afterPlotly.reactwith a freshPlotly.newPlot. The test fails onmainwithout the fix.colorbar,titlesBefore (4.1.1) and after (this fix). The right panel is a fresh
newPlotof the same figure.