Skip to content

(ignore) just having fun miso ramen - #8636

Draft
siddharthkp wants to merge 16 commits into
mainfrom
storybook/noodles-themed-page
Draft

siddharthkp wants to merge 16 commits into
mainfrom
storybook/noodles-themed-page

Conversation

@siddharthkp

@siddharthkp siddharthkp commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

No linked issue.

Exploring what would it be like to build Noodles with primer and a custom noodles theme.

The standalone story separates two concerns:

  • NoodlesPage.theme.module.css: Noodles theme variables and component overrides, including the hidden sidebar divider, menus, counters, buttons and headings.
  • NoodlesPage.stories.module.css: Story structure, artwork, layout, scrolling, reading width and responsive regions. It consumes tokens but defines no theme variables.

The story imports both CSS Modules explicitly. Menus and dialogs remain inside the themed portal scope. This split preserves every original CSS declaration and does not change appearance or interactions.

Changelog

New

  • A standalone Noodles story with fictional fixtures and local interactions, without appearance-playground controls or Storybook interaction tests.
  • Five optional ActionList/Button typography hooks with unchanged defaults, covered by the existing minor changeset.

Changed

  • Separate Noodles theme tokens and component overrides from the CSS required to lay out the story.
  • Keep the transparent sidebar-divider override in the theme, including its narrow-screen treatment. Native pointer/keyboard resizing and hover/focus feedback remain unchanged.

Removed

No functionality removed by this refactor.

Rollout strategy

  • No changes needed in github/github-ui
  • Needs changes in github/github-ui
  • Ships with feature flag(s)
  • Not sure
  • None

The theme is story-scoped. The existing minor changeset remains accurate for the optional component typography hooks; this story-only split needs no additional changeset.

Testing & Reviewing

  • node /Users/siddharth/.copilot/session-state/ffb7aa4f-c550-485f-b591-35469fa88108/files/verify-noodles-css-split.mjs before and node /Users/siddharth/.copilot/session-state/ffb7aa4f-c550-485f-b591-35469fa88108/files/verify-noodles-css-split.mjs — passed. Compared desktop, menu, dialog and mobile computed styles and geometry against the pre-split baseline. Only browser-dependent resolved insets on visually clipped dialog focus guards are excluded; their geometry is still checked.
  • node /Users/siddharth/.copilot/session-state/ffb7aa4f-c550-485f-b591-35469fa88108/files/verify-noodles-sidebar-divider.mjs — passed. The permanent line remains hidden; resize geometry, hover feedback and visible keyboard focus remain unchanged.
  • NOODLES_PORT=6008 node /Users/siddharth/.copilot/session-state/ffb7aa4f-c550-485f-b591-35469fa88108/files/verify-noodles-pagelayout.mjs and NOODLES_PORT=6008 node /Users/siddharth/.copilot/session-state/ffb7aa4f-c550-485f-b591-35469fa88108/files/verify-noodles-render-only.mjs — both passed. Native resize/bounds/reset, scrolling, focus mode, wide mode, comments, responsive layouts and manual page creation/reset remain working without JavaScript errors. Browser helpers are session-only, not included in the PR.
  • npx --no-install prettier --write packages/react/src/stories/NoodlesPage.stories.tsx packages/react/src/stories/NoodlesPage.stories.module.css packages/react/src/stories/NoodlesPage.theme.module.css — passed; git diff --cached --check — passed. A local PostCSS/source check also confirmed exact declaration preservation, no missing/unused CSS Module references, no theme-variable definitions in the story stylesheet and no added play functions.
  • Repository unit tests, builds, type checks, linters, accessibility/visual-regression suites and dependency installs were not run, as requested.

Preview: http://localhost:6008/?path=/story/examples-noodles-page--default

siddharthkp and others added 2 commits October 29, 2026 08:21
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@changeset-bot

changeset-bot Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3e24575

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Oct 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

@siddharthkp siddharthkp changed the title Storybook: add standalone Noodles-themed page (ignore) just having fun Oct 29, 2026
@primer

primer Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

🤖 Lint issues have been automatically fixed and committed to this PR.

@github-actions
github-actions Bot temporarily deployed to storybook-preview-8636 October 29, 2026 13:32 Inactive
@primer

primer Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

🤖 Lint issues have been automatically fixed and committed to this PR.

siddharthkp and others added 2 commits October 29, 2026 08:37
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions
github-actions Bot requested a deployment to storybook-preview-8636 October 29, 2026 13:41 Abandoned
@primer

primer Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

🤖 Lint issues have been automatically fixed and committed to this PR.

@github-actions
github-actions Bot requested a deployment to storybook-preview-8636 October 29, 2026 13:47 Abandoned
@primer

primer Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

🤖 Lint issues have been automatically fixed and committed to this PR.

siddharthkp and others added 2 commits October 29, 2026 09:43
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@siddharthkp siddharthkp changed the title (ignore) just having fun (ignore) just having fun miso ramen Oct 29, 2026
siddharthkp and others added 2 commits October 29, 2026 09:48
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@primer

primer Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

🤖 Lint issues have been automatically fixed and committed to this PR.

@github-actions
github-actions Bot temporarily deployed to storybook-preview-8636 October 29, 2026 14:52 Inactive
@primer

primer Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

🤖 Lint issues have been automatically fixed and committed to this PR.

siddharthkp and others added 2 commits October 29, 2026 10:07
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@siddharthkp siddharthkp mentioned this pull request Oct 29, 2026
1 of 5 tasks
siddharthkp and others added 2 commits October 30, 2026 09:10
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Inherit both stories and typography hooks from #8637. Keep only the story-scoped transparent sidebar divider as the stacked diff.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@siddharthkp siddharthkp added the skip changeset This change does not need a changelog label Oct 30, 2026
@siddharthkp
siddharthkp changed the base branch from main to storybook/noodles-primer-page October 30, 2026 14:12
Restore the standalone themed story and retain the transparent sidebar divider customization.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@siddharthkp siddharthkp removed the skip changeset This change does not need a changelog label Oct 30, 2026
@siddharthkp
siddharthkp changed the base branch from storybook/noodles-primer-page to main October 30, 2026 14:14
@github-actions
github-actions Bot requested a deployment to storybook-preview-8636 October 30, 2026 14:16 Abandoned
@primer

primer Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

🤖 Lint issues have been automatically fixed and committed to this PR.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@primer

primer Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

🤖 Lint issues have been automatically fixed and committed to this PR.

This branch was successfully deployed

2 active deployments
storybook-preview-8636 — 3e24575f Deployed Oct 30, 2026 by github-actions[bot]
github-pages — 3e24575f Deployed Oct 30, 2026 by siddharthkp via deploy-preview #33987
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant