Conversation
yugalkaushik
suggested changes
Nov 2, 2025
yugalkaushik
left a comment
yugalkaushik
left a comment
Contributor
There was a problem hiding this comment.
Hi @100xmanas thank you for the changes but web editor uses consistent styling and colors for all the components so fixed color are not suitable.
…100xmanas/p5.js-web-editor into improve-banner-styling-language
Contributor
Author
|
fixed! Apply consistent styling and colors to the banner If there's anything else, please let me know -- I'm happy to improve it further! 😊 |
Contributor
Author
|
Thanks for reviewing! |
raclim
added
Area:Accessibility
clairep94
approved these changes
Mar 7, 2026
Collaborator
|
@100xmanas Looks like there is a merge conflict on this branch. Could you take a look and resolve it? Thanks! |
Collaborator
|
@100xmanas Following up: are you able to resolve the merge conflicts in |
Collaborator
|
@100xmanas I ended up creating a new branch cut from Closing this PR now, and will merge your changes with #4328 |
doradocodes
added a commit
that referenced
this pull request
Sep 30, 2026
Resolving merge conflict for #3688
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3684
Description:
This PR improves the styling of the banner message when users switch languages.
before
500286459-e943c814-e7e3-40fd-82b0-7bf538e3475c.mov
After
1018.mp4
Changes:
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123