Repository navigation
[Ai slop]Deprecate and remove PytestPluginManager.getpluginIssue 5842 getplugin - #15188
Closed
gabrielesequeira wants to merge 4 commits into
Closed
gabrielesequeira wants to merge 4 commits into
gabrielesequeira wants to merge 4 commits into
Conversation
Author
|
Hi! While testing this change, I found that removing The relevant tests pass when the Hypothesis pytest plugin is disabled, but fail when it is enabled. How would you recommend proceeding? Should this removal be coordinated with a fix in Hypothesis, or would it be better to postpone the removal until dependent plugins have migrated to Thanks for your guidance! |
Member
|
Its absolutely ludicrous to do deprecation then removal into a single pr Deprecation and removal are months to years appart |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR deprecates and removes
PytestPluginManager.getplugin()in two steps:getplugin()as deprecated and migrate internal pytest usages toget_plugin().This change completes the transition to
get_plugin()as the supported API for retrieving registered plugins.Testing
pytest-xdistversion still calls the removedgetplugin()method.