Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

- Speed up membership tests (`key in ...`) on `Container`, `Table` and `InlineTable` with native `__contains__` implementations, avoiding the inherited `MutableMapping` round-trip through `__getitem__` (which resolves the value and builds an exception on every absent key). ([#483](https://github.com/python-poetry/tomlkit/issues/483))
- Speed up parsing by making `Source` index-based: it now tracks an integer position over the input string instead of materializing a list of `(index, char)` tuples up front, so construction is O(1) and state save/restore no longer copies an iterator. ([#489](https://github.com/python-poetry/tomlkit/pull/489))
- Speed up parsing by scanning character runs in bulk: `Source.advance_while`/`advance_until` consume a whole run of whitespace, bare-key or number characters in a single pass over the input string instead of one `inc()` call per character. ([#490](https://github.com/python-poetry/tomlkit/pull/490))

### Fixed

Expand Down
36 changes: 17 additions & 19 deletions tomlkit/parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,14 @@
CTRL_CHAR_LIMIT = 0x1F
CHR_DEL = 0x7F

# Character sets for Source.advance_while / advance_until bulk run scans
# (replace per-character `while self._current.is_*() and self.inc()` loops with
# a single underlying-string scan).
_SPACES_SET = frozenset(TOMLChar.SPACES)
_BARE_KEY_OR_SPACE = frozenset(TOMLChar.BARE + TOMLChar.SPACES)
_NUM_STOP = frozenset(" \t\n\r#,]}")
_DATE_TAIL_STOP = frozenset("\t\n\r#,]}")


class Parser:
"""
Expand Down Expand Up @@ -304,8 +312,7 @@ def _parse_comment_trail(self, parse_trail: bool = True) -> tuple[str, str, str]

trail = ""
if parse_trail:
while self._current.is_spaces() and self.inc():
pass
self._src.advance_while(_SPACES_SET)

if self._current == "\r":
with self._state(restore=True):
Expand All @@ -325,8 +332,7 @@ def _parse_key_value(self, parse_comment: bool = False) -> tuple[Key, Item]:
# Leading indent
self.mark()

while self._current.is_spaces() and self.inc():
pass
self._src.advance_while(_SPACES_SET)

indent = self.extract()

Expand Down Expand Up @@ -374,9 +380,8 @@ def _parse_key(self) -> Key:
WS before the key must be exhausted first at the callsite.
"""
self.mark()
while self._current.is_spaces() and self.inc():
# Skip any leading whitespace
pass
# Skip any leading whitespace (bulk scan)
self._src.advance_while(_SPACES_SET)
if self._current in "\"'":
return self._parse_quoted_key()
else:
Expand All @@ -401,8 +406,7 @@ def _parse_quoted_key(self) -> Key:
raise self.parse_error(UnexpectedCharError, key_str._t.value)
original += key_str.as_string()
self.mark()
while self._current.is_spaces() and self.inc():
pass
self._src.advance_while(_SPACES_SET)
original += self.extract()
result: Key = SingleKey(str(key_str), t=key_type, sep="", original=original)
if self._current == ".":
Expand All @@ -415,10 +419,7 @@ def _parse_bare_key(self) -> Key:
"""
Parses a bare key.
"""
while (
self._current.is_bare_key_char() or self._current.is_spaces()
) and self.inc():
pass
self._src.advance_while(_BARE_KEY_OR_SPACE)

original = self.extract()
key_s = original.strip()
Expand Down Expand Up @@ -467,8 +468,7 @@ def _parse_value(self) -> Item:
"nan",
}:
# Number
while self._current not in " \t\n\r#,]}" and self.inc():
pass
self._src.advance_until(_NUM_STOP)

raw = self.extract()

Expand All @@ -479,8 +479,7 @@ def _parse_value(self) -> Item:
raise self.parse_error(InvalidNumberError)
elif c in string.digits:
# Integer, Float, Date, Time or DateTime
while self._current not in " \t\n\r#,]}" and self.inc():
pass
self._src.advance_until(_NUM_STOP)

raw = self.extract()

Expand Down Expand Up @@ -512,8 +511,7 @@ def _parse_value(self) -> Item:
assert isinstance(dt, datetime.date)
date = Date(dt.year, dt.month, dt.day, trivia, raw)
self.mark()
while self._current not in "\t\n\r#,]}" and self.inc():
pass
self._src.advance_until(_DATE_TAIL_STOP)

time_raw = self.extract()
time_part = time_raw.rstrip()
Expand Down
42 changes: 42 additions & 0 deletions tomlkit/source.py
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,48 @@ def inc(self, exception: type[ParseError] | None = None) -> bool:
raise self.parse_error(exception) from None
return False

def advance_while(self, charset: frozenset) -> bool:
"""Advance while the current character is in ``charset``.

Equivalent to ``while self.current in charset and self.inc(): pass`` but
it scans the underlying string in a single pass and updates the index
and current character only once, instead of paying a per-character
``inc()`` call. On return ``current`` is the first character NOT in
``charset`` (or EOF). Returns ``True`` if it stopped on a real
character, ``False`` at EOF — the same value contract as the loop.
"""
i = self._idx
n = len(self)
while i < n and self[i] in charset:
i += 1
if i < n:
self._idx = i
self._current = TOMLChar(self[i])
return True
self._idx = n
self._current = self.EOF
return False

def advance_until(self, stopset: frozenset) -> bool:
"""Advance while the current character is NOT in ``stopset``.

The mirror of :meth:`advance_while`: equivalent to
``while self.current not in stopset and self.inc(): pass`` in a single
scan. On return ``current`` is the first character IN ``stopset`` (or
EOF), with the same return-value contract.
"""
i = self._idx
n = len(self)
while i < n and self[i] not in stopset:
i += 1
if i < n:
self._idx = i
self._current = TOMLChar(self[i])
return True
self._idx = n
self._current = self.EOF
return False

def inc_n(self, n: int, exception: type[ParseError] | None = None) -> bool:
"""
Increments the parser by n characters
Expand Down
Loading