Switch unstable_compactSourceMaps and unstable_allowIndexMap defaults to true (#1763)#1763
Open
robhogan wants to merge 1 commit into
Open
Switch unstable_compactSourceMaps and unstable_allowIndexMap defaults to true (#1763)#1763robhogan wants to merge 1 commit into
unstable_compactSourceMaps and unstable_allowIndexMap defaults to true (#1763)#1763robhogan wants to merge 1 commit into
Conversation
meta-codesync
Bot
force-pushed
the
export-D110759649
branch
from
051f012 to
51016e6
Compare
meta-cla
Bot
added
the
CLA Signed
…ults to `true` (#1763) Summary: Pull Request resolved: #1763 Flip these defaults to: - Change Metro's internal source map format to VLQ strings rather than decoded tuples - Emit [index maps](https://tc39.es/ecma426/#sec-index-source-map) for `.map` requests and programmatic and CLI source map builds. These are coupled, because allowing index maps without enabling compact source maps is a no-op, and enabling compact source maps without index maps is a performance regression for source map generation. Together, though, this reduces Metro's total memory footprint by more than 50%, and makes serving source maps ~2x faster. `/symbolicate` performance is preserved. ``` - **[Breaking]**: Metro now emits source maps as [index maps](https://tc39.es/ecma426/#sec-index-source-map). - **[Breaking]**: Custom serialisers now receive a module list with maps in `VlqMap` form (`module.output[].data.map`) ``` Reviewed By: GijsWeterings, hoxyq Differential Revision: D110759649
robhogan
force-pushed
the
export-D110759649
branch
from
51016e6 to
50ce77f
Compare
meta-codesync
Bot
changed the title
unstable_compactSourceMaps and unstable_allowIndexMap defaults to trueunstable_compactSourceMaps and unstable_allowIndexMap defaults to true (#1763)
Contributor
|
@robhogan has exported this pull request. If you are a Meta employee, you can view the originating Diff in D110759649. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Flip these defaults to:
.maprequests and programmatic and CLI source map builds.These are coupled, because allowing index maps without enabling compact source maps is a no-op, and enabling compact source maps without index maps is a performance regression for source map generation.
Together, though, this reduces Metro's total memory footprint by more than 50%, and makes serving source maps ~2x faster.
/symbolicateperformance is preserved.Reviewed By: GijsWeterings, hoxyq
Differential Revision: D110759649