You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@jderochervlk what's the motivation here? Make Base feature lighter and move it to DOM feature? IMO DOM feature (not DOM.res) is already quite big in itself plus you have to take into account its feature dependencies, it's likely around 90% of the whole project right now.
@jderochervlk what's the motivation here? Make Base feature lighter and move it to DOM feature? IMO DOM feature (not DOM.res) is already quite big in itself plus you have to take into account its feature dependencies, it's likely around 90% of the whole project right now.
I'm trying to slim down DOM.res as much as possible, you can see a larger lift in that direction on this PR: #287
DOM.res should eventually become DOM the feature, which should be lightweight. Not every project will need style sheet and CSS, so by moving this out you make using it opt in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves css and stylesheet related types out of DOM.