introduce ActionEndpointInfo from action graph.#3209
Conversation
Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com>
|
Tick the box to add this pull request to the merge queue (same as
|
There was a problem hiding this comment.
Pull request overview
Adds a new action-graph API to rclcpp_action which exposes aggregated endpoint information (goal/cancel/result services + feedback/status topics) via the new ActionEndpointInfo type, plus new graph query/count functions and accompanying tests.
Changes:
- Introduce
rclcpp_action::ActionEndpointInfoand public graph query functions ininclude/rclcpp_action/graph.hpp. - Implement graph queries/counting backed by
rcl_actiongraph APIs inrclcpp_action/src/graph.cpp. - Add
test_graphcoverage and wire the new source/test intorclcpp_action’s CMake build.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| rclcpp_action/test/test_graph.cpp | Adds unit tests for the new action graph info and counting APIs. |
| rclcpp_action/src/graph.cpp | Implements conversion and retrieval logic for action client/server endpoint info and counts. |
| rclcpp_action/include/rclcpp_action/rclcpp_action.hpp | Exposes the new graph API via the umbrella header. |
| rclcpp_action/include/rclcpp_action/graph.hpp | Declares the new ActionEndpointInfo API and graph query/count functions. |
| rclcpp_action/CMakeLists.txt | Builds/installs the new implementation file and adds the new gtest target. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com>
Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com>
|
Pulls: ros2/rcl#1326, #3209, ros2/rclpy#1697, ros2/ros2cli#1262 |
|
Pulls: ros2/rcl#1326, #3209, ros2/rclpy#1697, ros2/ros2cli#1262 |
Description
Part of ros2/ros2cli#1210
Fixes # (issue)
Is this user-facing behavior change?
No, new methods and APIs to support ActionEndpointInfo
Did you use Generative AI?
Yes, Claude Fable
Additional Information