Add value packing specs for more Enumerable and Enumerator::Lazy methods#1375
Open
sampokuokkanen wants to merge 1 commit into
Open
Add value packing specs for more Enumerable and Enumerator::Lazy methods#1375sampokuokkanen wants to merge 1 commit into
sampokuokkanen wants to merge 1 commit into
Conversation
Reuse the :enumerable_value_packing shared examples from ruby#1363 for drop, take_while, drop_while, select, reject and uniq, on both the eager Enumerable methods and their Enumerator::Lazy counterparts. compact and Enumerator::Lazy#with_index get dedicated examples since their output shape differs from the shared examples: compact removes the nil that a zero-argument yield packs to, and with_index pairs the packed value with the index ([packed_value, index]).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse the :enumerable_value_packing shared examples from #1363 for drop, take_while, drop_while, select, reject and uniq, on both the eager Enumerable methods and their Enumerator::Lazy counterparts.
compact and Enumerator::Lazy#with_index get dedicated examples since their output shape differs from the shared examples: compact removes the nil that a zero-argument yield packs to, and with_index pairs the packed value with the index ([packed_value, index]).