Skip to content

Improve Windows build process in build.rs - #2446

Closed
gugu8intel-i9 wants to merge 1 commit into
rust-lang:mainfrom
gugu8intel-i9:build.rs
Closed

gugu8intel-i9 wants to merge 1 commit into
rust-lang:mainfrom
gugu8intel-i9:build.rs

Conversation

@gugu8intel-i9

Copy link
Copy Markdown

Update the error handling for copying Cargo.toml on Windows.

Update the error handling for copying Cargo.toml on Windows.
@mo8it

mo8it commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

I think the error was ignored because it occurs when the file already exists or something like that. I don't see a need to improve it here since you will get an error later anyway.

@mo8it mo8it closed this Sep 7, 2026
@senekor

senekor commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

std::fs::copy will overwrite existing files, so the error must be something else. @gugu8intel-i9 should've said what their actual problem was though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants