Fix LT-22586: Normalize Word export content to NFC#970
Open
jasonleenaylor wants to merge 1 commit into
Open
Conversation
hahn-kev
reviewed
Jun 26, 2026
| //SUT | ||
| var result = ConfiguredLcmGenerator.GenerateContentForEntry(entry, mainEntryNode, null, DefaultSettings, 0) as DocFragment; | ||
| Assert.That(result, Is.Not.Null, "Results should have been generated"); | ||
| var tsResult = TsStringUtils.MakeString(result.ToString(), wsKo); |
There was a problem hiding this comment.
is there a reason we convert it into a ts string before testing?
Contributor
Author
There was a problem hiding this comment.
No, not really. It has a symmetry with the code setting the string in the model but it doesn't add any value. It is correct code with an unnecessary wrapper. I'll simplify it since you asked and made me think about it. :)
jasonleenaylor
commented
Jun 29, 2026
| //SUT | ||
| var result = ConfiguredLcmGenerator.GenerateContentForEntry(entry, mainEntryNode, null, DefaultSettings, 0) as DocFragment; | ||
| Assert.That(result, Is.Not.Null, "Results should have been generated"); | ||
| var tsResult = TsStringUtils.MakeString(result.ToString(), wsKo); |
Contributor
Author
There was a problem hiding this comment.
No, not really. It has a symmetry with the code setting the string in the model but it doesn't add any value. It is correct code with an unnecessary wrapper. I'll simplify it since you asked and made me think about it. :)
jasonleenaylor
force-pushed
the
bugfix/LT-22586
branch
from
23b9604 to
ff9933b
Compare
* Normalize the OpenXML <w:t> run text in place (new DocFragment.NormalizeText) and the letter-header string * Add regression tests GenerateWordDocForEntry_GeneratesNFC and GenerateLetterHeaderDocFragment_GeneratesNFC
jasonleenaylor
force-pushed
the
bugfix/LT-22586
branch
from
ff9933b to
ba60895
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
This change is