Fix LT-22581: Crash clicking Values expansion button#973
Open
jtmaxwell3 wants to merge 1 commit into
Open
Conversation
jasonleenaylor
requested changes
Jun 29, 2026
jasonleenaylor
left a comment
Contributor
There was a problem hiding this comment.
@jasonleenaylor made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on jtmaxwell3).
Src/Common/Controls/DetailControls/DataTree.cs line 5305 at r1 (raw file):
m_node = node; m_path = path; m_key = path.ToArray(); // This fixes LT-22581.
This seemed like too big of an oversight to have lived this long so I investigated a bit. There are multiple logic gates in the code which use a null key value as a sentinel. This will have behavior changes beyond the crash. I think a guard in the crash location might be better. You could even ask Claude to look for any other places where the key needs a guard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes https://jira.sil.org/browse/LT-22581. The code crashed because m_key wasn't initialized.
This change is