Better USFM versification analysis#432
Conversation
ddaspit
left a comment
There was a problem hiding this comment.
@ddaspit partially reviewed 10 files and all commit messages, and made 4 comments.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on Enkidu93).
src/SIL.Machine/Corpora/UsfmVersificationAnalyzer.cs line 16 at r1 (raw file):
} public class UsfmVersificationDiagnostic
Can we make this class immutable, or, at least, immutable externally?
src/SIL.Machine/Corpora/UsfmVersificationAnalyzer.cs line 69 at r1 (raw file):
} public class UsfmVersificationAnalyzer : UsfmParserHandlerBase
I would rename this to UsfmVersificationAnalyzerHandler. I got it confused with the UsfmVersificationAnalyzerBase class.
src/SIL.Machine/Corpora/UsfmVersificationAnalyzerBase.cs line 25 at r1 (raw file):
public UsfmVersificationAnalysis AnalyzeUsfmVersification( HashSet<string> books,
I would rename this to bookIds to differentiate it from the other overloaded method.
src/SIL.Machine/Corpora/UsfmVersificationAnalyzerBase.cs line 36 at r1 (raw file):
public UsfmVersificationAnalysis AnalyzeUsfmVersification( HashSet<int> books,
I would rename this to bookNums.
Fixes #405
Partially fixes #416
This change is