Skip to content

Better USFM versification analysis#432

Open
Enkidu93 wants to merge 2 commits into
masterfrom
better_usfm_versification_analysis
Open

Better USFM versification analysis#432
Enkidu93 wants to merge 2 commits into
masterfrom
better_usfm_versification_analysis

Conversation

@Enkidu93

@Enkidu93 Enkidu93 commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Fixes #405
Partially fixes #416


This change is Reviewable

@Enkidu93 Enkidu93 requested a review from ddaspit June 18, 2026 19:42

@ddaspit ddaspit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddaspit partially reviewed 10 files and all commit messages, and made 4 comments.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on Enkidu93).


src/SIL.Machine/Corpora/UsfmVersificationAnalyzer.cs line 16 at r1 (raw file):

    }

    public class UsfmVersificationDiagnostic

Can we make this class immutable, or, at least, immutable externally?


src/SIL.Machine/Corpora/UsfmVersificationAnalyzer.cs line 69 at r1 (raw file):

    }

    public class UsfmVersificationAnalyzer : UsfmParserHandlerBase

I would rename this to UsfmVersificationAnalyzerHandler. I got it confused with the UsfmVersificationAnalyzerBase class.


src/SIL.Machine/Corpora/UsfmVersificationAnalyzerBase.cs line 25 at r1 (raw file):

        public UsfmVersificationAnalysis AnalyzeUsfmVersification(
            HashSet<string> books,

I would rename this to bookIds to differentiate it from the other overloaded method.


src/SIL.Machine/Corpora/UsfmVersificationAnalyzerBase.cs line 36 at r1 (raw file):

        public UsfmVersificationAnalysis AnalyzeUsfmVersification(
            HashSet<int> books,

I would rename this to bookNums.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unexpected behavior when changing the versification of a verse range Improvements to UsfmVersificationErrorDetector

2 participants