Repository navigation
ntf server: validate APNS server certificate and host name - #1998
Draft
evgeny-simplex wants to merge 2 commits into
Draft
evgeny-simplex wants to merge 2 commits into
evgeny-simplex wants to merge 2 commits into
Conversation
evgeny-simplex
force-pushed
the
ep/ntf-apns-cert
branch
from
October 27, 2026 03:22
d11ebd3 to
4c00195
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ntf server: the APNs server certificate chain is validated against the CA store and the host name is checked, as the TLS library does by default. When the configured CA file cannot be loaded, the system certificate store is used, and the existing error line is logged. Connections that pin the server key (SMP, XFTP, remote control) are unchanged.
tests: the notification server connects to an APNs mock with the configured CA file and, when that file is missing, with the system store; it is refused with another CA and with a wrong host name.