Skip to content

improvement(ui): drop full-content hover tooltips - #6128

Merged
waleedlatif1 merged 2 commits into
stagingfrom
improvement/remove-content-tooltips
Jul 31, 2026
Merged

improvement(ui): drop full-content hover tooltips#6128
waleedlatif1 merged 2 commits into
stagingfrom
improvement/remove-content-tooltips

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Remove the chunk-content tooltip in the KB chunks table — it passed showWhen, which bypassed the clip gate and forced the entire chunk body into a tooltip on every truncated row
  • Remove the sub-block value tooltip on collapsed workflow blocks (whole prompts / code / JSON on hover); the short sub-block title keeps its clip-gated tooltip
  • Replace the native title attribute on subflow (loop/parallel) and note blocks with the clip-gated OverflowSpan — those fired the raw browser tooltip unconditionally, even on fully visible names, against the rule documented in overflow-span.tsx
  • Clip-gate the KB documents tags cell so it stops firing when the tags are already fully visible (the name: value breakdown is preserved when the text is actually clipped)
  • Drop the dead tooltip on the resource header root title — that span is whitespace-nowrap inside a shrink-0 container, so it could never clip and the tooltip could never fire

Left alone: clip-gated tooltips on names/labels (table cells, filenames, workflow names, breadcrumbs), icon-only connector chips, and the canvas badge tooltips that convey a click affordance.

Type of Change

  • Bug fix

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Jul 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview Jul 31, 2026 7:42pm

Request Review

@cursor

cursor Bot commented Jul 31, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Presentation-only tooltip behavior changes with no auth, data, or API impact; low regression risk aside from users who relied on full-value hovers.

Overview
Removes or tightens hover tooltips that showed full untruncated text even when nothing was clipped, and aligns canvas blocks with the clip-gated OverflowSpan pattern.

Knowledge & resource UI: Chunk table rows no longer use overflow tooltips for content (including cases where showWhen forced the whole chunk body on hover). The documents tags column uses a new DocumentTagsCell that only shows the name: value breakdown when inline tag text is clipped. The resource header root title drops overflow tooltip wiring because the label is whitespace-nowrap in a non-shrinking container and cannot truncate.

Workflow canvas: Loop/parallel and note block titles switch from native title to OverflowSpan so tooltips appear only when names are actually clipped. Collapsed sub-block rows keep clip-gated tooltips on titles but remove them from values (prompts, code, JSON) so hovering no longer dumps entire field contents.

Reviewed by Cursor Bugbot for commit aef1aee. Configure here.

@greptile-apps

greptile-apps Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR removes unconditional full-content tooltips and consistently clip-gates remaining overflow tooltips.

  • Removes tooltips for chunk bodies, collapsed sub-block values, and the non-clipping resource title.
  • Replaces native title attributes on note and subflow names with OverflowSpan.
  • Shows document tag details only when the inline tag values are clipped.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains; the previously reported optional note-name typing issue is fixed by supplying an empty-string fallback to OverflowSpan.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/components/resource/components/resource-header/resource-header.tsx Replaces the unreachable overflow tooltip on the non-shrinking resource title with plain text.
apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/document.tsx Removes full chunk-content hover tooltips while retaining truncated preview rendering.
apps/sim/app/workspace/[workspaceId]/knowledge/[id]/base.tsx Introduces a tags cell whose detailed tooltip appears only when the inline values are clipped.
packages/workflow-renderer/src/note/note-block-view.tsx Replaces the native note-name title with a clip-gated OverflowSpan and safely handles omitted names.
packages/workflow-renderer/src/subflow/subflow-node-view.tsx Replaces the native subflow-name title with a clip-gated OverflowSpan.
packages/workflow-renderer/src/workflow-block/sub-block-row-view.tsx Removes full-value hover tooltips from collapsed workflow sub-block rows.

Reviews (2): Last reviewed commit: "fix(workflow-renderer): default the opti..." | Re-trigger Greptile

Comment thread packages/workflow-renderer/src/note/note-block-view.tsx Outdated
- remove the chunk-content tooltip in the KB chunks table (it forced the full chunk body on every truncated row)
- remove the sub-block value tooltip on collapsed workflow blocks (whole prompts/code/JSON on hover)
- replace the native `title` on subflow and note blocks with the clip-gated OverflowSpan
- clip-gate the KB documents tags cell so it stops firing on fully visible tags
- drop the dead tooltip on the resource header root title, which can never truncate
@waleedlatif1
waleedlatif1 force-pushed the improvement/remove-content-tooltips branch from d693723 to aef1aee Compare July 31, 2026 19:37
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit aef1aee. Configure here.

@waleedlatif1
waleedlatif1 merged commit 5c29d83 into staging Jul 31, 2026
27 checks passed
@waleedlatif1
waleedlatif1 deleted the improvement/remove-content-tooltips branch July 31, 2026 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant