Skip to content

improvement(ui): share browser toolbar actions - #8068

Open
BillLeoutsakosvl346 wants to merge 2 commits into
stagingfrom
codex/control-fix-browser-toolbar-actions
Open

BillLeoutsakosvl346 wants to merge 2 commits into
stagingfrom
codex/control-fix-browser-toolbar-actions

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Summary

  • Share five browser navigation and utility actions through one local EMCN Button composition.
  • Preserve 30px geometry, menu anchor refs, disabled navigation and download progress content.

Type of Change

  • Refactor / maintainability improvement

Testing

  • Full workspace type checks, lint, repository audits (including import and API validation), generators and docs checks pass.
  • External source comparison confirms caller logic and content are unchanged.
  • Original and extracted components have matching computed styles in light/dark browser fixtures; keyboard, disabled and expansion behavior checked. These are isolated fixtures, not full authenticated product flows.
  • Relevant existing tests pass. No landing-page changes or audit tooling included.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 20, 2026 10:57pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge because the latest change resolves the prior props-interface requirement without introducing a type or behavioral regression.

Summary

This PR extracts shared browser toolbar button configuration into a reusable component while preserving existing navigation, menu-anchor, disabled-state, and download behavior.

  • Centralizes the fixed button type, variant, size, and 30px geometry.
  • Reuses the component for back, forward, reload, password-fill, and downloads actions.
  • Updates the props declaration to the repository-required interface form.

Reviews (2) · Last reviewed commit: "fix(ui): align shared control props with..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant