Skip to content

improvement(ui): share bulk action bar surfaces - #8077

Open
BillLeoutsakosvl346 wants to merge 1 commit into
codex/emcn-consolidationfrom
codex/control-fix-bulk-action-bar
Open

BillLeoutsakosvl346 wants to merge 1 commit into
codex/emcn-consolidationfrom
codex/control-fix-bulk-action-bar

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Summary

  • Add the shared BulkActionBar surface and use it for resource, knowledge and table selections.
  • Keep selection limits, inline selection actions, permissions, positioning, animation and command handlers in the callers; retain existing geometry and colors.

Type of Change

  • Refactor / maintainability improvement

Testing

  • Full workspace type checks, lint, repository audits (including import and API validation), generators and docs checks pass.
  • Complete EMCN test suite and relevant existing consumer suites pass.
  • Before/after browser fixtures cover light/dark styling, narrow layouts and the affected interaction patterns. Fixtures are isolated controls, not full authenticated product flows.
  • No landing-page changes or audit tooling included.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 21, 2026 12:57am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the shared component preserves the behavior and presentation of all three existing action bars.

Summary

This PR extracts the duplicated selection-action surface into a shared EMCN BulkActionBar and adopts it in the resource, knowledge, and table action bars.

  • Preserves caller-owned visibility, positioning, animation, permission checks, selection limits, and command handlers.
  • Exports the new component and its props through the public @sim/emcn entrypoint.
  • Retains the existing surface geometry, colors, spacing, and action-button composition.

Reviews (1) · Last reviewed commit: "improvement(ui): share bulk action bar s..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant