Skip to content

improvement(ui): share missing resource states - #8078

Open
BillLeoutsakosvl346 wants to merge 2 commits into
stagingfrom
codex/control-fix-resource-empty-state
Open

BillLeoutsakosvl346 wants to merge 2 commits into
stagingfrom
codex/control-fix-resource-empty-state

Conversation

@BillLeoutsakosvl346

@BillLeoutsakosvl346 BillLeoutsakosvl346 commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add ResourceEmptyState for missing resources and replace seven product screens with the shared icon/title/description layout.
  • Retain the 32px icon, 20px heading and spacing. Center wrapped text and normalize neutral text contrast and remove the obsolete ResourceNotFound wrapper.

Type of Change

  • Refactor / maintainability improvement

Testing

  • Full workspace type checks, lint, repository audits (including import and API validation), generators and docs checks pass.
  • Complete EMCN test suite and relevant existing consumer suites pass.
  • Before/after browser fixtures cover light/dark styling, narrow layouts and the affected interaction patterns. Fixtures are isolated controls, not full authenticated product flows.
  • No landing-page changes or audit tooling included.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 21, 2026 1:09am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge because the latest change only centers empty-state text and no actionable regression or outstanding requirement violation was identified.

Summary

This PR consolidates missing-resource presentation into a shared ResourceEmptyState component.

  • Replaces duplicated missing-state markup across workflows, files, folders, logs, knowledge resources, documents, and tables.
  • Preserves the existing icon, heading, description, spacing, and full-height centered layout.
  • Centers wrapped text consistently and removes the obsolete app-local wrapper.

Reviews (2) · Last reviewed commit: "fix(ui): center wrapped resource message..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 8 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread packages/emcn/src/components/resource-empty-state/resource-empty-state.tsx Outdated
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 8 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant