Skip to content

improvement(ui): use chips for ordinary product actions - #8081

Open
BillLeoutsakosvl346 wants to merge 2 commits into
codex/control-fix-search-replace-fieldsfrom
codex/control-fix-ordinary-chip-actions
Open

BillLeoutsakosvl346 wants to merge 2 commits into
codex/control-fix-search-replace-fieldsfrom
codex/control-fix-ordinary-chip-actions

Conversation

@BillLeoutsakosvl346

@BillLeoutsakosvl346 BillLeoutsakosvl346 commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replace eight individually styled text actions with existing Chip variants.
  • Preserve handlers, disabled conditions and full-width filters; normalize height, corners and typography for clear filters, pagination, generation, replacement and preview navigation. The static preview label shares the same chip geometry; full-width Clear filters uses the standard left-aligned label.

Type of Change

  • Refactor / maintainability improvement

Testing

  • Full workspace type checks, lint, repository audits (including import and API validation), generators and docs checks pass.
  • Complete EMCN test suite and relevant existing consumer suites pass.
  • Before/after browser fixtures cover light/dark styling, narrow layouts and the affected interaction patterns. Fixtures are isolated controls, not full authenticated product flows.
  • No landing-page changes or audit tooling included.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 21, 2026 1:09am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; no outstanding correctness, security, or repository-rule issues were identified.

Summary

This PR replaces individually styled workspace actions with shared Chip variants while preserving their handlers and disabled states. The follow-up change also aligns the preview workflow-name label with the shared chip visual system.

  • Converts file and log filter-reset actions to full-width chips.
  • Converts pagination, license generation, and search-replacement actions to standard chip variants.
  • Converts preview navigation and its adjacent workflow label to shared chip geometry and typography.

Reviews (2) · Last reviewed commit: "fix(ui): align preview labels with chip ..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 6 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant