Skip to content

improvement(ui): use a chip for PII configuration - #8083

Open
BillLeoutsakosvl346 wants to merge 1 commit into
stagingfrom
codex/control-fix-pii-configure-trigger
Open

BillLeoutsakosvl346 wants to merge 1 commit into
stagingfrom
codex/control-fix-pii-configure-trigger

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Summary

  • Use a full-width Chip with icon and selected-count adornment for Configure PII Types.
  • Keep the grouped-checkbox modal, selection state and workflow-search behavior; replace the local button chrome with the existing border-shadow treatment.

Type of Change

  • Refactor / maintainability improvement

Testing

  • Full workspace type checks, lint, repository audits (including import and API validation), generators and docs checks pass.
  • Complete EMCN test suite and relevant existing consumer suites pass.
  • Before/after browser fixtures cover light/dark styling, narrow layouts and the affected interaction patterns. Fixtures are isolated controls, not full authenticated product flows.
  • No landing-page changes or audit tooling included.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 21, 2026 12:58am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the replacement Chip preserves the trigger’s interaction, disabled state, accessibility semantics, and responsive layout.

Summary

Replaces the Configure PII Types button with the existing full-width border-shadow Chip while preserving the selection count and modal workflow.

  • Uses the ManageWorkspace icon through the Chip API.
  • Moves the selected-count display into the right adornment.
  • Updates selected-count text to the body text token.

Reviews (1) · Last reviewed commit: "improvement(ui): use a chip for PII conf..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant