Skip to content

improvement(ui): reuse chips for custom block upload actions - #8084

Open
BillLeoutsakosvl346 wants to merge 5 commits into
codex/emcn-consolidationfrom
codex/control-fix-resource-comboboxes
Open

BillLeoutsakosvl346 wants to merge 5 commits into
codex/emcn-consolidationfrom
codex/control-fix-resource-comboboxes

Conversation

@BillLeoutsakosvl346

@BillLeoutsakosvl346 BillLeoutsakosvl346 commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Use the existing outlined Chip for custom-block Upload/Change and the icon Button for Remove.
  • Center the actions beside the preview and preserve upload callbacks, accepted file types, loading states and permission guards.

Type of Change

  • Refactor / maintainability improvement

Testing

  • All workspace type checks, repository lint, audits (including import and API validation), and generated-artifact checks pass.
  • Complete EMCN suite and relevant existing consumer tests pass.
  • Existing real-component browser fixtures cover both themes, narrow layouts, enlarged text, disabled states and local upload/change/remove callbacks. These do not exercise the live upload service.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 21, 2026 4:17am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 8 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge because the control refactor preserves the existing interaction, accessibility, and permission behavior.

Summary

This PR updates the custom-block icon controls to use the shared Chip treatment for Upload/Change and the icon-sized Button treatment for Remove.

  • Preserves upload, change, and removal callbacks.
  • Preserves loading and permission-based disabled states.
  • Vertically centers the action controls beside the icon preview.

Reviews (3) · Last reviewed commit: "fix(ui): retain existing workflow resour..."

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 10 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Co-authored-by: Bill Leoutsakos <billleoutsakos@Mac.localdomain>
@BillLeoutsakosvl346 BillLeoutsakosvl346 changed the title improvement(ui): reuse chip comboboxes for workflow resources improvement(ui): reuse chips for custom block upload actions Sep 21, 2026
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant