Skip to content

improvement(ui): use chip selects for bounded workflow choices - #8085

Closed
BillLeoutsakosvl346 wants to merge 2 commits into
codex/control-fix-parameter-cardsfrom
codex/control-fix-bounded-choice-menus
Closed

BillLeoutsakosvl346 wants to merge 2 commits into
codex/control-fix-parameter-cardsfrom
codex/control-fix-bounded-choice-menus

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Summary

  • Use ChipSelect for seven fixed-choice workflow controls: sort direction, filter logic/operator, booleans, input type and tool permission mode.
  • Preserve stored values, disabled options and highlighted labels. Map empty values to placeholders and keep permission hints in menu rows, with a plain selected label.

Type of Change

  • Refactor / maintainability improvement

Testing

  • Full workspace type checks, lint, repository audits (including import and API validation), generators and docs checks pass.
  • Complete EMCN test suite and relevant existing consumer suites pass.
  • Before/after browser fixtures cover light/dark styling, narrow layouts and the affected interaction patterns. Fixtures are isolated controls, not full authenticated product flows.
  • No landing-page changes or audit tooling included.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 21, 2026 12:59am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; no actionable behavioral, security, or repository-rule violations were identified.

Summary

This PR consistently migrates seven bounded workflow-editor choices from the legacy Combobox to ChipSelect while retaining stored values, read-only behavior, search highlighting, disabled permission modes, and menu-only permission hints.

  • Updates filter logic/operator and sort-direction selectors.
  • Updates starter field type/value and variable boolean selectors.
  • Updates tool permission mode selection and adds keyboard-focused coverage for disabled options and selection behavior.

Reviews (1) · Last reviewed commit: "improvement(ui): use chip selects for bo..."

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

Closing because removing the partial editor restyling leaves no source changes. The existing EMCN controls and their behavior remain unchanged.

@waleedlatif1
waleedlatif1 deleted the codex/control-fix-bounded-choice-menus branch September 21, 2026 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant