Skip to content

fix(emcn): preserve editable combobox overlay text visibility - #8086

Open
BillLeoutsakosvl346 wants to merge 4 commits into
codex/control-fix-parameter-cardsfrom
codex/control-fix-remaining-workflow-pickers
Open

fix(emcn): preserve editable combobox overlay text visibility#8086
BillLeoutsakosvl346 wants to merge 4 commits into
codex/control-fix-parameter-cardsfrom
codex/control-fix-remaining-workflow-pickers

Conversation

@BillLeoutsakosvl346

@BillLeoutsakosvl346 BillLeoutsakosvl346 commented Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Keep editable Combobox input text transparent beneath formatted label and selected-icon overlays, even when caller classes specify a text color.
  • Preserve caller styling and ordinary text visibility when no overlay is present.

Type of Change

  • Bug fix

Testing

  • All workspace type checks, repository lint, audits (including import and API validation), and generated-artifact checks pass.
  • Complete EMCN suite and relevant existing consumer tests pass.
  • Focused regression coverage checks formatted-label, selected-icon and no-overlay cases with caller text-color overrides.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@BillLeoutsakosvl346

BillLeoutsakosvl346 commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

@greptile

@vercel

vercel Bot commented Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 21, 2026 4:24am UTC

Request Review

@BillLeoutsakosvl346

BillLeoutsakosvl346 commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with no outstanding correctness, security, or repository-rule issues.

Summary

This PR fixes editable Combobox overlay rendering by applying text transparency after caller-provided classes, preventing formatted labels or selected icons from visually overlapping the input value.

  • Preserves transparent input text whenever a formatted-label or selected-icon overlay is active.
  • Preserves caller-defined text colors when no overlay is present.
  • Adds regression coverage for label, icon, and no-overlay states.

Reviews (4) · Last reviewed commit: "fix(test): import chip combobox through ..."

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Sep 21, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 18 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Sep 21, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 18 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346 BillLeoutsakosvl346 changed the title improvement(ui): reuse chip controls for remaining workflow pickers fix(emcn): preserve editable combobox overlay text visibility Sep 21, 2026
@BillLeoutsakosvl346
BillLeoutsakosvl346 changed the base branch from codex/control-fix-bounded-choice-menus to codex/control-fix-parameter-cards September 21, 2026 04:17
@BillLeoutsakosvl346

BillLeoutsakosvl346 commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

BillLeoutsakosvl346 commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Sep 21, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

greptile-apps[bot]
greptile-apps Bot reviewed Sep 21, 2026
View reviewed changes
Comment thread packages/emcn/src/components/combobox/combobox.dom.test.tsx Outdated
@BillLeoutsakosvl346

BillLeoutsakosvl346 commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

BillLeoutsakosvl346 commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Sep 21, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

greptile-apps[bot]
greptile-apps Bot reviewed Sep 21, 2026
View reviewed changes
Comment thread packages/emcn/src/components/combobox/combobox.dom.test.tsx
@BillLeoutsakosvl346

BillLeoutsakosvl346 commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

BillLeoutsakosvl346 commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Sep 21, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments
@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@BillLeoutsakosvl346