[Web] Refactor Touchable not to rely on GestureDetector#4344
Open
j-piasecki wants to merge 4 commits into
Open
[Web] Refactor Touchable not to rely on GestureDetector#4344j-piasecki wants to merge 4 commits into
Touchable not to rely on GestureDetector#4344j-piasecki wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ActionType.NONEis added on the JS side; the webGestureHandlerskipssendEventdispatch for handlers attached with it.GestureHandlerButton.web.tsxnow creates and attaches its ownNativeViewGestureHandlerwhenhandlerTagis set (mirroring the native platforms) and drops it on unmount.NativeViewGestureHandlerruns the same press state machine (including the long-press timer) when it manages a button, dispatching press events as DOMCustomEvents (gh:buttonPressetc.). The button listens for these and forwards them to theonButton*callbacks; managed buttons no longer drive pressed state from their own pointer handlers.Touchable.web.tsxis deleted — web now uses the sharedTouchableimplementation.GestureHandlerregistering event listeners for initially disabled handlers (config is applied before attachment, so the enabled-change path never ran) — covered by a new unit test.Test plan
Existing tests in the Example app