Repository navigation
Conversation
In `tensorflow_quantum/core/serialize/serializer_test.py`, `test_serialize_circuit_wrong_type` and `test_deserialize_circuit_wrong_type` were passing `input` instead of the actual parameterized test argument, `inp`. Because `input` exists:(it's a Python built-in), but is neither a `cirq.Circuit` nor a `tfq.proto.Program`, `TypeError` was raised by accident, masking that the parameterized values (`'wrong'`, `1.0`, `None`, `[]`) were never passed into the serializer functions. Fix: `input` → `inp`.
mhucka
changed the title
serializer_test.py
mhucka
marked this pull request as ready for review
October 27, 2026 22:47
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request corrects a bug in tensorflow_quantum/core/serialize/serializer_test.py where the test methods test_serialize_circuit_wrong_type and test_deserialize_circuit_wrong_type incorrectly referenced the Python built-in input instead of the passed parameter inp. I have no feedback to provide as there are no review comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
tensorflow_quantum/core/serialize/serializer_test.py,test_serialize_circuit_wrong_typeandtest_deserialize_circuit_wrong_typepassedinputinstead of the actual parameter,inp. Because the symbolinputdoes exist in Python (it's a Python built-in), but it's neither acirq.Circuitnor atfq.proto.Program,TypeErrorwould get raised, masking that the parameterized values ('wrong',1.0,None,[]) were never passed into the serializer functions.Fix: replace
inputbyinp.