Fix Issue #2385#2386
Open
BrandonIrizarry wants to merge 2 commits into
Open
Conversation
This intentionally creates a failing test. We're trying to prove that,
if we have mutually exclusive flags that look like:
{ { A, B }, { C, D } }
It should be the case that any combination that draws from both sets
should result in an error. However, currently this isn't the case; for
example, the code considers the combination "--A --D" to be legal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bugfix
What this PR does / why we need it:
Mutual exclusion wasn't being properly enforced when using MutuallyExclusiveFlags.
flag_mutex_test.go
flag_mutex.go
checkto pass the breaking test.Which issue(s) this PR fixes:
Fixes #2385
Testing
I ran
make testat the project root.Release Notes
(REQUIRED)