Skip to content

chore: polish cuDF C FFI#8358

Merged
0ax1 merged 1 commit into
developfrom
perf/cudf-ffi-session-header
Jun 12, 2026
Merged

chore: polish cuDF C FFI#8358
0ax1 merged 1 commit into
developfrom
perf/cudf-ffi-session-header

Conversation

@0ax1

@0ax1 0ax1 commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Add vx_cuda_session_new so C FFI callers can create a CUDA-enabled Vortex session once and reuse it across Arrow Device exports.

Document the CUDA export sync_event lifetime and guard the Arrow C Device definitions in vortex_cuda.h with ARROW_C_DEVICE_DATA_INTERFACE, preserving USE_OWN_ARROW_DEVICE as an opt-out.

@0ax1 0ax1 requested a review from a team June 11, 2026 13:42
@0ax1 0ax1 changed the title feat: reusable CUDA session, sync_event docs, and Arrow guard in cuDF FFI feat: polish cuDF C FFI Jun 11, 2026
@0ax1

0ax1 commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

@claude review

@github-actions

Copy link
Copy Markdown
Contributor

Claude review automation is disabled for pull requests that modify .github/ files.

Why:

  • workflow and action files are part of the automation policy
  • this review workflow refuses to evaluate automation changes from the same PR

Ask a human reviewer to inspect workflow changes directly.

@0ax1 0ax1 added the changelog/chore A trivial change label Jun 11, 2026
@0ax1 0ax1 changed the title feat: polish cuDF C FFI chore: polish cuDF C FFI Jun 11, 2026
@0ax1 0ax1 marked this pull request as draft June 11, 2026 13:48
@codspeed-hq

codspeed-hq Bot commented Jun 11, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 19.45%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 6 improved benchmarks
❌ 106 regressed benchmarks
✅ 1416 untouched benchmarks
⏩ 10 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation compare[48] 213 µs 300.7 µs -29.16%
Simulation compare[50] 227.7 µs 319.2 µs -28.65%
Simulation compare[49] 228.2 µs 317.7 µs -28.19%
Simulation compare[44] 207.5 µs 287.7 µs -27.88%
Simulation compare[46] 218.5 µs 302.5 µs -27.76%
Simulation compare[47] 223.5 µs 309.4 µs -27.75%
Simulation compare[40] 190.7 µs 263.5 µs -27.64%
Simulation compare[44] 212.2 µs 292.4 µs -27.43%
Simulation compare[45] 218.9 µs 301 µs -27.28%
Simulation compare[43] 209.2 µs 287.7 µs -27.26%
Simulation compare[42] 204.6 µs 281.1 µs -27.22%
Simulation compare[40] 195.6 µs 268.4 µs -27.1%
Simulation compare[43] 214.2 µs 292.6 µs -26.79%
Simulation compare[42] 209.4 µs 285.9 µs -26.76%
Simulation compare[41] 204.5 µs 279.2 µs -26.74%
Simulation compare[41] 209.3 µs 284 µs -26.29%
Simulation compare[39] 199.9 µs 270.8 µs -26.19%
Simulation compare[31] 157.7 µs 213.7 µs -26.19%
Simulation compare[38] 195.5 µs 264.6 µs -26.11%
Simulation compare[36] 187.3 µs 252.6 µs -25.87%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing perf/cudf-ffi-session-header (98f5bbb) with develop (3731d5b)

Open in CodSpeed

Footnotes

  1. 10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions

Copy link
Copy Markdown
Contributor

Claude review automation is disabled for pull requests that modify .github/ files.

Why:

  • workflow and action files are part of the automation policy
  • this review workflow refuses to evaluate automation changes from the same PR

Ask a human reviewer to inspect workflow changes directly.

@0ax1 0ax1 force-pushed the perf/cudf-ffi-session-header branch 3 times, most recently from 018c60f to 28b9586 Compare June 12, 2026 12:48
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
@0ax1 0ax1 force-pushed the perf/cudf-ffi-session-header branch from 28b9586 to 98f5bbb Compare June 12, 2026 12:55
@0ax1 0ax1 requested a review from myrrc June 12, 2026 13:01
@0ax1 0ax1 marked this pull request as ready for review June 12, 2026 13:01
@0ax1 0ax1 requested review from onursatici and robert3005 June 12, 2026 13:01
@0ax1 0ax1 merged commit 89b1092 into develop Jun 12, 2026
67 of 70 checks passed
@0ax1 0ax1 deleted the perf/cudf-ffi-session-header branch June 12, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants