Skip to content

Install libc debug symbols for codspeed benchmarks#8384

Merged
AdamGS merged 1 commit into
developfrom
adamg/codspeed-libc-dbg
Jun 12, 2026
Merged

Install libc debug symbols for codspeed benchmarks#8384
AdamGS merged 1 commit into
developfrom
adamg/codspeed-libc-dbg

Conversation

@AdamGS

@AdamGS AdamGS commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Summary

Install libc's debug symbols for codspeed runs, to get better symbolication for some of the code we end up calling.

For example, for the noisy chunked_bool_canonical_into we currently get (note the unknown spans on the left):
Screenshot 2026-06-12 at 09 03 39

With this change we get (note all the new blue spans, other colors are just noise):
Screenshot 2026-06-12 at 09 04 22

They include both memory allocation function but often more useful to us - SIMD instructions! On this PR's runs with a quick look I've found:

  • _int_malloc
  • malloc_consolidate
  • __memset_avx2_unaligned_erms
  • __memcpy_avx_unaligned_erms
  • __memcmp_avx2_movbe
  • tcache_get_n

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@codspeed-hq

codspeed-hq Bot commented Jun 12, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 17.99%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

❌ 6 regressed benchmarks
✅ 1520 untouched benchmarks
⏩ 10 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_bool_canonical_into[(1000, 10)] 20.4 µs 35.4 µs -42.42%
Simulation chunked_varbinview_into_canonical[(1000, 10)] 176.8 µs 212.9 µs -16.98%
Simulation chunked_varbinview_canonical_into[(100, 100)] 272.7 µs 307.9 µs -11.41%
Simulation encode_varbin[(1000, 4)] 142.9 µs 159.9 µs -10.61%
Simulation encode_varbin[(1000, 8)] 143.6 µs 160.6 µs -10.61%
Simulation encode_varbin[(1000, 32)] 148.5 µs 165.2 µs -10.09%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing adamg/codspeed-libc-dbg (b4882ac) with develop (c6a0b7b)

Open in CodSpeed

Footnotes

  1. 10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@AdamGS AdamGS requested a review from 0ax1 June 12, 2026 08:10
@AdamGS AdamGS requested a review from myrrc June 12, 2026 08:10
@AdamGS AdamGS marked this pull request as ready for review June 12, 2026 08:11
@AdamGS AdamGS requested a review from a team June 12, 2026 08:11

@0ax1 0ax1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@AdamGS AdamGS merged commit a74a42f into develop Jun 12, 2026
81 of 85 checks passed
@AdamGS AdamGS deleted the adamg/codspeed-libc-dbg branch June 12, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants