Skip to content

Validate all rustdoc builds#8386

Merged
AdamGS merged 3 commits into
developfrom
adamg/validate-all-rustdoc
Jun 12, 2026
Merged

Validate all rustdoc builds#8386
AdamGS merged 3 commits into
developfrom
adamg/validate-all-rustdoc

Conversation

@AdamGS

@AdamGS AdamGS commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Summary

Make sure to actually build rustdoc for all features and crates in the workspace, including private docs.

This PR also includes fixes for every failure I've found. In some cases we had references to dead types/interfaces, I've tried to keep the intent as close as possible to original intent.

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS requested review from a team, 0ax1 and joseph-isaacs June 12, 2026 09:42
@AdamGS AdamGS added the changelog/docs A docs change label Jun 12, 2026
@AdamGS AdamGS changed the title Validate all rustdoc Validate all rustdoc builds Jun 12, 2026
@codspeed-hq

codspeed-hq Bot commented Jun 12, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 11.47%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 3 improved benchmarks
✅ 1523 untouched benchmarks
⏩ 10 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation bitwise_not_vortex_buffer_mut[128] 244.4 ns 215.3 ns +13.55%
Simulation bitwise_not_vortex_buffer_mut[1024] 304.7 ns 275.6 ns +10.58%
WallTime cuda/bitpacked_u16/unpack/5bw[100M] 615.9 µs 558.4 µs +10.29%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing adamg/validate-all-rustdoc (490bac3) with develop (50bee6e)

Open in CodSpeed

Footnotes

  1. 10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

AdamGS added 2 commits June 12, 2026 10:59
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS merged commit c7e0d17 into develop Jun 12, 2026
66 of 67 checks passed
@AdamGS AdamGS deleted the adamg/validate-all-rustdoc branch June 12, 2026 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/docs A docs change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants