fix(ui): render markdown tables - #2840
Conversation
|
@alectimison-maker is attempting to deploy a commit to the esokullu's projects Team on Vercel. A member of the Team first needs to authorize it. |
Render pipe tables before ATX headings so a table on the next line is not glued onto the heading, and serialize rendered tables back to Markdown in chat history. Co-authored-by: Cursor <cursoragent@cursor.com>
Review findings (fixed in 9e7f610)Pushed follow-up commit P1 — Render tables before headings P2 — Persist tables as Markdown, not flattened cells
|
Summary
Motivation
Responses containing a header row, separator row, and pipe-delimited data rows were displayed as literal Markdown instead of a table. This is the user-visible failure reported in #2838.
Design
Testing
node test/run.js— 1850 passed; 1 pre-existing failure for the missing tracked artifactdist/webbrain-chrome-32.1.0.zipin the Opera-safe license filename check.node --check src/chrome/src/ui/markdown-render.js && node --check src/chrome/src/ui/sidepanel.js && node --check src/firefox/src/ui/markdown-render.js && node --check src/firefox/src/ui/sidepanel.js— passed.npm run test:toolbar-guard— passed (33 tests).npm run test:security— passed (60/60 checks).sidepanel.html— passed; injected issue table rendered as one table withoverflow-x: auto, and no page or console errors.Firefox live browser verification was not available; Firefox parity is covered by the mirrored source and regression assertions.
Compatibility and risks
Scope
Closes #2838