fix(ui): respect IME composition in composer - #2844
Merged
esokullu merged 1 commit intoAug 18, 2026
Merged
Conversation
The composer intercepted the Enter key used to commit an active IME composition before the input method could finalize the text.
|
@alectimison-maker is attempting to deploy a commit to the esokullu's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
When using a non-English input method, Enter may be required to commit the current composition before the text is complete. The composer previously called
preventDefault()andsendMessage()for that keydown, so the input method could not commit the text. This fixes #2841.Design
user-inputkeydown handler whenevent.isComposingis true or the browser reports the IME fallbackkeyCode === 229.Testing
node test/run.js— 1852 passed; 2 pre-existing upstream baseline failures: the changelog completeness check and the missingdist/webbrain-chrome-32.1.0.zipartifact check.node --check src/chrome/src/ui/sidepanel.js && node --check src/firefox/src/ui/sidepanel.js— passed.npm run test:toolbar-guard— passed (33 tests).npm run test:security— passed (60/60 checks).defaultPrevented: false, preservedEnglish draft, and created no user message.web-ext lint— passed witherrors: 0,notices: 0, and 92 existing warnings.Firefox live sidepanel automation was attempted after installing Firefox 153.0.4 locally, but Firefox Remote Agent rejects direct navigation to the privileged
moz-extension://URL. Firefox source parity and browser-neutral regression coverage are included; native Firefox IME interaction remains untested.Compatibility and risks
keyCodeis used only as a compatibility fallback for IME composition; normal Enter remains keyCode 13 and keeps existing behavior.Scope
Closes #2841