Skip to content

chore(frontend): remove the unused UserWorkflowListItemComponent - #8463

Open
aglinxinyuan wants to merge 1 commit into
apache:mainfrom
aglinxinyuan:chore/fe-list-item
Open

chore(frontend): remove the unused UserWorkflowListItemComponent#8463
aglinxinyuan wants to merge 1 commit into
apache:mainfrom
aglinxinyuan:chore/fe-list-item

Conversation

@aglinxinyuan

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

Deletes UserWorkflowListItemComponent, which is declared in AppModule but whose selector texera-user-workflow-list-item appears in no template — so it is never rendered. HighlightSearchTermsPipe goes with it, because the component's own template is the pipe's last remaining consumer. Pure deletion, no behaviour change: −1,104 lines.

History

Introduced by #1937 (2023-05-30) — "Refactored each workflow list item into its own component"
Usage removed by #2793 (2024-08-20) — "Generalize List Item" replaced it with the generic ListItemComponent, deleting the last two texera-user-workflow-list-item uses from search-results.component.html

Dead for about two years.

Reviewer note — why the pipe is in the same PR. HighlightSearchTermsPipe arrived in #2386 and kept a second consumer until #7463 (2026-08-29, "remove the deprecated project feature") dropped entry.name | highlightSearchTerms from that template. Since then its only use is this dead component's template (L43/L106). Removing the component alone would leave the pipe dead in the same commit, so they ship together; splitting them would just create a second PR for code this one already orphans.

Nothing else needs cleaning: WorkflowExecutionHistoryComponent, ShareAccessComponent, DownloadService, GuiConfigService and WorkflowPersistService all keep other consumers.

Any related issues, documentation, discussions?

Closes #8460

How was this PR tested?

Existing tests only — this PR removes a component, a pipe, and the two specs that covered them.

From frontend/:

  • npx ng buildsuccess. This is the gate that matters here: removing an AppModule declaration can only be proven safe by an AOT build, since template diagnostics are AOT-only. A leftover use of either selector would fail it.
  • npx ng test --watch=false --include='**/user-workflow.component.spec.ts' — 75 tests pass after dropping the two inert TestBed references.
  • yarn --cwd frontend format:ci — clean.

Verification, re-runnable by a reviewer:

git grep -n "texera-user-workflow-list-item\|UserWorkflowListItemComponent"
git grep -n "highlightSearchTerms\|HighlightSearchTermsPipe"

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Claude Opus 5)

Copilot AI lite review requested due to automatic review settings September 9, 2026 05:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added the frontend Changes related to the frontend GUI label Sep 9, 2026
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • Contributors with relevant context: @tanishqgandhi1908
    You can notify them by mentioning @tanishqgandhi1908 in a comment.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.92%. Comparing base (bda3400) to head (ab35bc6).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8463      +/-   ##
============================================
- Coverage     93.94%   93.92%   -0.03%     
  Complexity     4826     4826              
============================================
  Files          1209     1206       -3     
  Lines         49705    49584     -121     
  Branches       6074     6063      -11     
============================================
- Hits          46694    46570     -124     
- Misses         1522     1524       +2     
- Partials       1489     1490       +1     
Flag Coverage Δ *Carryforward flag
access-control-service 80.18% <ø> (ø) Carriedforward from bda3400
agent-service 99.32% <ø> (ø) Carriedforward from bda3400
amber 89.91% <ø> (ø) Carriedforward from bda3400
computing-unit-managing-service 75.05% <ø> (ø) Carriedforward from bda3400
config-service 87.12% <ø> (ø) Carriedforward from bda3400
file-service 83.65% <ø> (ø) Carriedforward from bda3400
frontend 96.74% <ø> (-0.04%) ⬇️
notebook-migration-service 83.73% <ø> (ø) Carriedforward from bda3400
pyamber 98.47% <ø> (ø) Carriedforward from bda3400
workflow-compiling-service 77.19% <ø> (ø) Carriedforward from bda3400

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Changes related to the frontend GUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the unused UserWorkflowListItemComponent and HighlightSearchTermsPipe

3 participants