chore(frontend): remove the unused UserWorkflowListItemComponent - #8463
Open
aglinxinyuan wants to merge 1 commit into
Open
chore(frontend): remove the unused UserWorkflowListItemComponent#8463aglinxinyuan wants to merge 1 commit into
aglinxinyuan wants to merge 1 commit into
Conversation
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8463 +/- ##
============================================
- Coverage 93.94% 93.92% -0.03%
Complexity 4826 4826
============================================
Files 1209 1206 -3
Lines 49705 49584 -121
Branches 6074 6063 -11
============================================
- Hits 46694 46570 -124
- Misses 1522 1524 +2
- Partials 1489 1490 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Deletes
UserWorkflowListItemComponent, which is declared inAppModulebut whose selectortexera-user-workflow-list-itemappears in no template — so it is never rendered.HighlightSearchTermsPipegoes with it, because the component's own template is the pipe's last remaining consumer. Pure deletion, no behaviour change: −1,104 lines.History
ListItemComponent, deleting the last twotexera-user-workflow-list-itemuses fromsearch-results.component.htmlDead for about two years.
Any related issues, documentation, discussions?
Closes #8460
How was this PR tested?
Existing tests only — this PR removes a component, a pipe, and the two specs that covered them.
From
frontend/:npx ng build— success. This is the gate that matters here: removing anAppModuledeclaration can only be proven safe by an AOT build, since template diagnostics are AOT-only. A leftover use of either selector would fail it.npx ng test --watch=false --include='**/user-workflow.component.spec.ts'— 75 tests pass after dropping the two inertTestBedreferences.yarn --cwd frontend format:ci— clean.Verification, re-runnable by a reviewer:
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5)