Skip to content

chore(frontend): remove the unused UserWorkflowListItemComponent #8463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aglinxinyuan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(frontend): remove the unused UserWorkflowListItemComponent #8463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions frontend/src/app/app.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,6 @@ import { MarkdownModule } from "ngx-markdown";
import { FileSaverService } from "./dashboard/service/user/file/file-saver.service";
import { DragDropModule } from "@angular/cdk/drag-drop";
import { ScrollingModule } from "@angular/cdk/scrolling";
import { UserWorkflowListItemComponent } from "./dashboard/component/user/user-workflow/user-workflow-list-item/user-workflow-list-item.component";
import { SortButtonComponent } from "./dashboard/component/user/sort-button/sort-button.component";
import { FiltersComponent } from "./dashboard/component/user/filters/filters.component";
import { FiltersInstructionsComponent } from "./dashboard/component/user/filters-instructions/filters-instructions.component";
Expand All @@ -139,7 +138,6 @@ import { TimeTravelComponent } from "./workspace/component/left-panel/time-trave
import { NzModalModule } from "ng-zorro-antd/modal";
import { NzDescriptionsModule } from "ng-zorro-antd/descriptions";
import { OverlayModule } from "@angular/cdk/overlay";
import { HighlightSearchTermsPipe } from "./dashboard/component/user/user-workflow/user-workflow-list-item/highlight-search-terms.pipe";
import { en_US, provideNzI18n } from "ng-zorro-antd/i18n";
import { FilesUploaderComponent } from "./dashboard/component/user/files-uploader/files-uploader.component";
import { ConflictingFileModalContentComponent } from "./dashboard/component/user/files-uploader/conflicting-file-modal-content/conflicting-file-modal-content.component";
Expand Down Expand Up @@ -330,15 +328,13 @@ registerLocaleData(en);
CollabWrapperComponent,
AboutComponent,
TexeraLoginComponent,
UserWorkflowListItemComponent,
SortButtonComponent,
FiltersComponent,
FiltersInstructionsComponent,
SearchComponent,
PortPropertyEditFrameComponent,
WorkflowRuntimeStatisticsComponent,
FlarumComponent,
HighlightSearchTermsPipe,
SearchBarComponent,
ListItemComponent,

@Yicong-Huang Yicong-Huang Sep 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Advisory:

The cleanup stops one file short. dashboard/component/section-style.scss:130-199 sits under the comment "css specifically for each workflow item in the list". It holds .workflow-list-item and everything nested under it, plus the .metadata-container rules at :123 and :213. Base-tree grep shows the deleted user-workflow-list-item.component.html was the sole applier of every one of those classes. That leaves roughly 70 dead lines in a partial seven component stylesheets @use. Dead CSS renders nothing, so no behavior is wrong either way, but it is the same deletion, and leaving it means the next person redoes this grep. One dangling reference goes with it: search-results.component.html:27 cites .workflow-list-item as the authority for itemSize="70", already stale since #2793.

CardItemComponent,
Expand Down
67 changes: 0 additions & 67 deletions .../component/user/user-workflow/user-workflow-list-item/highlight-search-terms.pipe.spec.ts
View file
Open in desktop

This file was deleted.

40 changes: 0 additions & 40 deletions ...board/component/user/user-workflow/user-workflow-list-item/highlight-search-terms.pipe.ts
View file
Open in desktop

This file was deleted.

210 changes: 0 additions & 210 deletions ...mponent/user/user-workflow/user-workflow-list-item/user-workflow-list-item.component.html
View file
Open in desktop

This file was deleted.

21 changes: 0 additions & 21 deletions ...mponent/user/user-workflow/user-workflow-list-item/user-workflow-list-item.component.scss
View file
Open in desktop

This file was deleted.

Loading
Loading