Repository navigation
Improve PHP 8.4+ support by avoiding implicitly nullable types - #46
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The compatibility changes are consistent, tested, and preserve the documented legacy PHP support.
0 open findings
What changed in this PR
Improves PHP 8.4 compatibility while retaining PHP 5.3 support.
Changes:
- Replaces implicitly nullable loop types with manual validation and tests.
- Updates ReactPHP dependencies and adds PHP 8.4 CI coverage.
- Temporarily suppresses a known
react/mysqldeprecation.
| File | Description |
|---|---|
src/SshSocksConnector.php |
Adds manual loop validation. |
src/SshProcessConnector.php |
Adds manual loop validation. |
tests/SshSocksConnectorTest.php |
Tests invalid loop handling. |
tests/SshProcessConnectorTest.php |
Tests invalid loop handling. |
examples/31-mysql-ssh-tunnel.php |
Suppresses the known MySQL deprecation. |
composer.json |
Raises dependency minimum versions. |
.github/workflows/ci.yml |
Adds PHP 8.4 testing. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset improves PHP 8.4+ support by avoiding implicitly nullable types as discussed in reactphp/promise#260. The same idea applies, but v1 requires manual type checks to support legacy PHP versions as the nullable type syntax requires PHP 7.1+ otherwise.
The
react/mysqldev dependency used in one example is still affected until its upcoming v0.7.0 release (see friends-of-reactphp/mysql#203), so this example temporarily ignores the resulting deprecation notices.Builds on top of #45, clue/reactphp-socks#123, reactphp/promise#260, reactphp/socket#318, reactphp/child-process#114, reactphp/stream#179 and others
Refs #41