Repository navigation
[video_player_videohole] Fix value update after dispose and WebVTT cues without identifier - #1182
Merged
seungsoo47 merged 2 commits intoOct 13, 2026
Conversation
seekTo() awaits the platform call and then calls _updatePosition(), so when the controller is disposed while a seek is pending, the late completion sets value on a disposed ValueNotifier and debug builds throw "A VideoPlayerController was used after being disposed". The periodic position and duration timers have the same race through _updatePosition() and _updateDuration(), and play() sets value after awaiting its seek to the start. Return early in all of these when the controller is disposed. This package's controller was copied from upstream video_player, which has the same code and fixed _updatePosition() the same way in video_player 2.14.1: flutter/packages#12971
A cue was treated as having an identifier whenever it had more than two lines, so a multi-line cue without an identifier used its first text line as the timing line and was dropped. Detect the identifier by checking whether the first line is the timing line instead. This package's WebVTT parser was copied from upstream video_player, which has the same code and fixed it the same way in video_player 2.9.3: flutter/packages#8555
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
gin7773
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes:
The controller and WebVTT parser in this package were copied from upstream
video_player, which has the same code and fixed it the same way: