[video_player_videohole] Fix value update after dispose and WebVTT cues without identifier

packages/video_player_videohole/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 0.6.1
+
+* Fix a "used after being disposed" error when a seek, position, or duration update completes after the controller is disposed.
+* Fix multi-line WebVTT cues without an identifier being dropped.
+
 ## 0.6.0
 
 * Migrate from Platform Channels to Dart FFI.

packages/video_player_videohole/README.md

@@ -12,7 +12,7 @@ To use this package, add `video_player_videohole` as a dependency in your `pubsp
 
 ```yaml
 dependencies:
-  video_player_videohole: ^0.6.0
+  video_player_videohole: ^0.6.1
 ```
 
 Then you can import `video_player_videohole` in your Dart code:

packages/video_player_videohole/lib/src/web_vtt.dart

@@ -48,8 +48,8 @@ List<Caption> _parseCaptionsFromWebVTTString(String file) {
       continue;
     }
 
-    // Caption has header
-    final bool hasHeader = captionLines.length > 2;
+    // See: https://www.w3.org/TR/webvtt1/#webvtt-cue-identifier for valid cue identifier
+    final bool hasHeader = !captionLines[0].contains(_webVTTArrow);
     if (hasHeader) {
       final int? tryParseCaptionNumber = int.tryParse(captionLines[0]);
       if (tryParseCaptionNumber != null) {

packages/video_player_videohole/lib/video_player.dart

@@ -574,6 +574,9 @@ class VideoPlayerController extends ValueNotifier<VideoPlayerValue> {
   Future<void> play() async {
     if (value.position == value.duration.end) {
       await seekTo(Duration.zero);
+      if (_isDisposed) {
+        return;
+      }
     }
     value = value.copyWith(isPlaying: true);
     await _applyPlayPause();
@@ -844,6 +847,9 @@ class VideoPlayerController extends ValueNotifier<VideoPlayerValue> {
   }
 
   void _updatePosition(Duration position) {
+    if (_isDisposed) {
+      return;
+    }
     value = value.copyWith(
       position: position,
       caption: _getCaptionAt(position),
@@ -852,6 +858,9 @@ class VideoPlayerController extends ValueNotifier<VideoPlayerValue> {
   }
 
   void _updateDuration(DurationRange duration) {
+    if (_isDisposed) {
+      return;
+    }
     value = value.copyWith(duration: duration);
   }
 

packages/video_player_videohole/pubspec.yaml

@@ -2,7 +2,7 @@ name: video_player_videohole
 description: Flutter plugin for displaying inline video on Tizen TV devices.
 homepage: https://github.com/flutter-tizen/plugins
 repository: https://github.com/flutter-tizen/plugins/tree/main/packages/video_player_videohole
-version: 0.6.0
+version: 0.6.1
 
 environment:
   sdk: ">=3.1.0 <4.0.0"